diff --git a/docs/superpowers/plans/2026-08-05-movementtest-solver-timeout.md b/docs/superpowers/plans/2026-08-05-movementtest-solver-timeout.md index 7df9e9e..dc5edac 100644 --- a/docs/superpowers/plans/2026-08-05-movementtest-solver-timeout.md +++ b/docs/superpowers/plans/2026-08-05-movementtest-solver-timeout.md @@ -31,7 +31,7 @@ - Consumes: `TrajectoryObservationSettings.CreateValidatedSnapshot()` and `TrajectoryObservationController.StartCycle(...)`. - Produces: `TrajectoryObservationSettings.SolverTimeoutSeconds`, copied to `EmPlanningRequest.Configuration.Scheduling.SolverTimeoutSeconds`. -- [ ] **Step 1: Write the failing test** +- [x] **Step 1: Write the failing test** In `VerifiesControllerBuildsSegmentZeroRequest`, set a non-default observation setting and assert it reaches the request: @@ -47,7 +47,7 @@ Verification.NearlyEqual(0.42d, planningService.Requests[0].Configuration.Schedu Also extend `VerifiesSettingsSnapshotAndVehicle` to assert that a default snapshot retains `0.50d`, and extend `RejectsInvalidSettings` with `settings => settings.SolverTimeoutSeconds = 0d`. -- [ ] **Step 2: Run the focused verification to verify it fails** +- [x] **Step 2: Run the focused verification to verify it fails** Run: @@ -57,7 +57,7 @@ dotnet run --project ClumsyPilot/tests/EMPlannerVerificationHost/EMPlannerVerifi Expected: FAIL because `SolverTimeoutSeconds` does not yet exist or its value is not propagated to the request. -- [ ] **Step 3: Write the minimal implementation** +- [x] **Step 3: Write the minimal implementation** Add and copy/validate the settings property: @@ -73,7 +73,7 @@ configuration.Scheduling.SolverTimeoutSeconds = settings.SolverTimeoutSeconds; Do not alter the EM default configuration or any tolerance property. -- [ ] **Step 4: Run focused verification to verify it passes** +- [x] **Step 4: Run focused verification to verify it passes** Run: @@ -83,7 +83,7 @@ dotnet run --project ClumsyPilot/tests/EMPlannerVerificationHost/EMPlannerVerifi Expected: all trajectory-observation checks pass, including timeout propagation and invalid-setting rejection. -- [ ] **Step 5: Run the related EM regression suite** +- [x] **Step 5: Run the related EM regression suite** Run: @@ -94,10 +94,9 @@ dotnet build ClumsyPilot/ClumsyPilot.csproj --no-restore Expected: both commands finish successfully with no errors. -- [ ] **Step 6: Commit the implementation** +- [x] **Step 6: Commit the implementation** ```powershell git add ClumsyPilot/tests/EMPlannerVerificationHost/TrajectoryObservationChecks.cs ClumsyPilot/ParkrobTrajplanner/tarjplanner_movementtest/TrajectoryObservationContracts.cs ClumsyPilot/ParkrobTrajplanner/tarjplanner_movementtest/MovementTest.TrajectoryObservationTest.cs ClumsyPilot/ParkrobTrajplanner/tarjplanner_movementtest/TrajectoryObservationPipeline.cs git commit -m "feat: configure MovementTest solver timeout" ``` -