7.5 KiB
Path smoothing six-figure report implementation plan
Execution: Implement in this workspace without staging or committing. The worktree contains unrelated user changes; touch only the path-smoothing report code, its tests, and its documentation.
Goal: Replace each scenario's legacy composite comparison.svg/png output with six focused SVG/PNG figures and one CSV, using discrete trajectory samples only (no path-connecting strokes).
Architecture: Keep SmoothingFigureModel as the immutable source data extracted from comparison results. Add a figure-set layer that selects series, camera bounds, map decorations, axis configuration, and title/legend per output figure. Both renderers consume that same figure definition, so SVG and PNG communicate exactly the same data. The exporter creates all twelve images and the CSV in temporary sibling files, then publishes the completed set and removes legacy composite images.
Technology: C#/.NET 10 (System.Drawing.Common for PNG); hand-authored SVG; existing PowerShell verification harness and PathSmoothingPngVerificationHost.
Task 1: Define six figure views from the common report model
Files:
- Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingFigureModel.cs - Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingFigureModelBuilder.cs - Create:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingFigureKind.cs - Create:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingFigureDefinition.cs - Create:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingFigureSetBuilder.cs - Modify:
ClumsyPilot/tests/PathSmoothingPngVerificationHost/Program.cs
- Extend the C# verification host first with assertions for six ordered figure kinds/stems, selected series, equal-scale world bounds, labels with units, and point-only series metadata. Run the host and confirm it fails because no figure set exists.
- Remove
DashArrayas a trajectory styling contract fromSmoothingFigureSeriesand legend entries. Preserve source points, status, colors, raw baseline flag, violations, map obstacles, start, goal, and metric rows. - Implement immutable figure definitions with fixed stems:
01-coarse-path-overview: raw only; map obstacles and start/goal.02-all-paths-comparison: raw plus all three smoothing methods; paths and axes/legend only.03-cubic-bspline-overview,04-local-cubic-bezier-overview,05-piecewise-quintic-overview: faded raw reference plus the named method; map obstacles and start/goal.06-curvature-comparison: raw plus all smoother curvature samples.
- Compute a trajectory-driven world view for each overhead figure: union only visible series points plus its relevant start/goal, add 10% padding with a 0.25 m minimum extent, and expand the smaller world dimension so projected X and Y scale are equal. Do not use full map bounds to zoom out a figure.
- Include deterministic “nice” axis ticks/labels in metres for overhead figures and arc length/curvature units for the final figure. Preserve failed/infeasible method labels in legends even when their geometry has no points.
- Rerun the host checks; expected result: it passes definition-level checks while renderer-output checks remain to be updated in Tasks 2–3.
Task 2: Render six focused point-cloud figures and publish the set
Files:
- Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingSvgRenderer.cs - Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingPngRenderer.cs - Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingReportExporter.cs - Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Visualization/SmoothingReportExportResult.cs - Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/Test/PathSmoothingComparisonDemo.cs - Modify:
ClumsyPilot/tests/PathSmoothingPngVerificationHost/Program.cs
- Add output-level tests in the verification host for the twelve exact image names, the single CSV, non-empty parseable SVGs, readable 600 dpi PNGs, and absence of temporary files. Run them and confirm the legacy one-image exporter fails these expectations.
- Refactor the SVG renderer to render one figure definition at a time. Draw axes, ticks, numeric labels, unit labels, legend point swatches, map rectangles (when requested), and start/goal markers. Draw every trajectory and curvature sample as a small marker; do not emit a trajectory
<path>, polyline, dash array, or line segment. - Apply the identical layout semantics in the PNG renderer. Draw points rather than calling a line-drawing API for path samples; give raw reference samples a reduced alpha in individual smoother figures. Keep 600 dpi metadata and the existing required-font behavior.
- Refactor the exporter to build the six definitions and write twelve temporary image files plus the CSV before publishing. Return collections of SVG and PNG paths with the one CSV path. Delete
comparison.svg/pngafter a successful new-set publish; on failure, clean temporary files and retain existing published outputs. - Update demo/host call sites from singular
SvgPath/PngPathto the path collections. Run the verification host; expected result: six SVGs, six PNGs, and CSV are all present and valid.
Task 3: Update external verification, runner documentation, and visually inspect outputs
Files:
- Modify:
ClumsyPilot/tests/verify_path_smoothing_svg_csv.ps1 - Modify:
ClumsyPilot/tests/verify_path_smoothing_png.ps1 - Modify:
ClumsyPilot/tests/verify_path_smoothing_documentation.ps1 - Modify:
ClumsyPilot/ParkrobTrajplanner/PathSmoothing/README.md - Modify:
ClumsyPilot/tests/run_path_smoothing_comparison.ps1(only if it states/assumes legacy filenames) - Modify:
docs/superpowers/specs/2026-07-30-path-smoothing-six-figure-report-design.md(only if implementation exposes a necessary clarified contract)
- Update PowerShell tests to assert exactly six SVG + six PNG filenames, one CSV, no legacy composite output, required unit labels, marker-based trajectory rendering, and no trajectory dash/line styles. Ensure test source uses safe UTF-8 handling rather than brittle localized literal matching.
- Update the README to document the six filenames, marker-only semantics, method statuses, coordinate units, and the one-command runner output structure.
- Run the focused report verification scripts and the PNG host. Regenerate at least one fixture report with the current 0.025 m smoothing output sampling.
- Render/open representative PNGs for visual QA: raw overview, all-path overlay, each individual smoother, and curvature. Check that curves fill the frame, coordinates/units are legible, all points are visible, individual figures retain context, and there are no joined path lines.
- Run
dotnet build ClumsyPilot/ClumsyPilot.csproj --no-restoreand relevant contract/service/integration tests. Confirmgit diff --checkand report exact files changed; do not stage or commit.
Acceptance checklist
- Each scenario produces exactly
01through06SVGs and corresponding PNGs plus one CSV. - Raw and smoothed trajectories use every sampled point and zero connecting lines.
- Overhead figures use equal X/Y scale, trajectory-focused bounds, numeric axes, and metre units.
- Curvature uses
s (m)andκ (m⁻¹)axes with a complete legend and statuses. - SVG and PNG agree on the six figure contents, fonts, units, colors, and point-only semantics.
- Every PNG is 600 dpi; failed export leaves no temporary files or partial newly generated set.